perf(ci): trim renderer, Storybook and CLI candidate waits - #5419
Draft
orangeCatDeveloper wants to merge 1 commit into
Draft
orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
The renderer architecture check parses only apps/desktop, so plan it from those paths instead of every code change, and parse the base tree on a worker thread instead of after the current one. Build the Storybook the smoke renders without the manager, docgen and sourcemaps nothing opens, and let the CLI candidate reuse the workspaces the Build step just compiled instead of cleaning and recompiling them. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three core-CI steps did work nothing consumed.
Check renderer architectureran on every code change although it parses onlyapps/desktop, and parsed the base tree after the current one;Build Storybookbuilt the manager, docgen and sourcemaps for a smoke that opensiframe.htmlonly;Build CLI release candidatecleaned and recompiled the workspaces theBuildstep had just compiled. Plan the renderer check from the paths it reads, parse the base tree on a worker thread, build the smoke Storybook with--test --preview-only, and let the candidate reuse the compiled workspaces via a new--reuse-buildflag that is only accepted with--allow-dirty, so release builds still clean.Expected saving per run on Apache runners: about 45 s when a PR touches
apps/desktop, about 70 s when it does not.performance-frontend.ymlkeeps the production Storybook build its measurements are calibrated against.Verification
Controlled A/B on a fork, one runner per arm, identical plan (
BASE_SHAset, full suite). Per-step seconds; the unchanged steps agree within 2 % between arms.Local,
apps/desktop:node scripts/check-renderer-architecture.mjs --base HEAD --strict-base6.0 s -> 3.7 s; the checker's own suite stays at 3.5 s (112 passed).storybook build --test --preview-only9.1 s -> 3.3 s locally with the smoke unchanged at 57 s.scripts/ci-test-plan.test.mjs,scripts/ci-workflow-policy.test.mjs: 87 passedapps/desktop/scripts/check-renderer-architecture.test.mjs: 112 passed--reuse-buildpath end to end outside the fork A/B; the candidate it produced passedValidate installed CLI release candidatethere.Review focus
--reuse-buildis the one change that skips a step: the candidate tarball is packed from thedist/theBuildstep produced instead of a clean recompile. It is CI-only (--allow-dirtyis required), and a real release still runsbuildFromCleanDependencyTree.AI use
Select exactly one:
Tool(s) and scope: Claude Code profiled the steps, wrote the planner gate, the worker-thread split, the Storybook flags and the
--reuse-buildflag, and ran the fork A/B.Checklist
Does this PR entail a change in behavior?