docs(usage): track review follow-ups for #5387 - #5410
Draft
Sun-GLiang wants to merge 1 commit into
Draft
Sun-GLiang wants to merge 1 commit into
Sun-GLiang wants to merge 1 commit into
Conversation
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track the quality findings that Astro-Han approved as follow-up work in the review of #5387 at
e4c4abe48. #5387 establishes a complete, revision-consistent Settings Usage screen; the follow-up discussion asks for fixes at the shared validation and paging boundaries.This Draft PR starts with a scope document on
main. It records the problems and acceptance criteria so implementation can be added and reviewed here after #5387 lands. The current commit changes no runtime behavior.Refs #5387
Verification
git diff --cached --checkchecks; the commit hook ran successfully.Follow-up scope
session_metadataINSERT/DELETE invalidation churn and narrow it if material without losing correctness coverage.readUsageScreenin the store drain barrier and test the close race.displayedRangehook result.usage:activityrequest kind at its IPC boundary.usageStatscontract.If the removed Astryx pagination patch is reintroduced, cover its source-condition build as well as distributed JavaScript and declarations. The later source-condition review applies to that removed patch.
AI use
Tool(s) and scope: Codex drafted the tracking document and this PR description from the linked review findings.
Checklist
Does this PR entail a change in behavior?