KNOX-3421 - Upgrade Shiro to 2.2.1 - #1353
Merged
Merged
Conversation
moresandeep
requested review from
hanicz,
pzampino and
smolnar82
and removed request for
smolnar82
August 20, 2026 21:02
Test Results 3 files 3 suites 8s ⏱️ Results for commit af4b7ef. ♻️ This comment has been updated with latest results. |
hanicz
requested changes
Aug 21, 2026
hanicz
left a comment
hanicz
left a comment
Contributor
There was a problem hiding this comment.
Did you test caching as well?
This was referenced Aug 21, 2026
Contributor
Author
|
Thanks for the review @hanicz, i addressed the comments and also added docker tests for LDAP caching. |
hanicz
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
Knox 3421 - Upgrade Shiro to 2.2.1
What changes were proposed in this pull request?
How was this patch tested?
Integration Tests
test_knox_ldap_dn_injection.py