HBASE-30316 Add Docker build modes and user-friendly tooling - #8530
Open
mnpoonia wants to merge 1 commit into
Open
HBASE-30316 Add Docker build modes and user-friendly tooling#8530mnpoonia wants to merge 1 commit into
mnpoonia wants to merge 1 commit into
Conversation
mnpoonia
force-pushed
the
feature/hbase-vote-docker
branch
3 times, most recently
from
August 5, 2026 15:22
6d2b332 to
9e0d14a
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves dev-support/hbase_docker by adding multiple Docker build input modes (GitHub tag/branch, local tarball, local source directory) and introducing a single build-hbase.sh entrypoint intended to make building/running HBase-in-Docker more user-friendly.
Changes:
- Extend Dockerfiles to support
INPUT_MODE(tag,tarball,source-dir) for flexible build inputs. - Add
build-hbase.shwrapper script to unify build flows and auto-select the Apple Silicon Dockerfile. - Replace/update documentation and
.dockerignorebehavior to better support local tarball/source inputs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| dev-support/hbase_docker/README.md | Rewritten user-focused documentation for the new build modes and script usage. |
| dev-support/hbase_docker/Dockerfile | Adds INPUT_MODE handling and build-context staging logic. |
| dev-support/hbase_docker/.dockerignore | Restricts context by default while allowing tarball or hbase/** inclusion. |
| dev-support/hbase_docker/build-hbase.sh | New unified build script for tag/tarball/source-dir workflows. |
| dev-support/hbase_docker/m1/Dockerfile | Mirrors INPUT_MODE logic for Apple Silicon host usage. |
| dev-support/hbase_docker/m1/.dockerignore | Adds ignore rules for the m1 build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mnpoonia
force-pushed
the
feature/hbase-vote-docker
branch
from
August 5, 2026 17:16
9e0d14a to
96722e4
Compare
Extends hbase_docker to support three input modes and adds unified
build script for better user experience.
Changes:
- Dockerfile: Add INPUT_MODE build arg (tag/tarball/source-dir)
- tag: Clone from GitHub (default, unchanged behavior)
- tarball: Build from local tarball file
- source-dir: Build from local source directory
- build-hbase.sh: Unified script with user-friendly interface
- Prerequisites validation (Docker, disk space)
- Auto-setup and cleanup
- Clear progress indicators and error messages
- Supports --tag, --tarball, and --source flags
- README.md: User-first documentation
- Progressive disclosure (simple → advanced)
- Real workflows for three audiences (learners, developers,
release managers)
- Maven usage inside containers
- Volume mount guide for persistent changes
- .dockerignore: Proper source directory inclusion
Target audiences:
- New users learning HBase (3-command quickstart)
- Developers testing local changes (uncommitted changes supported)
- Release managers verifying RCs (tarball mode)
All modes tested and working. Backward compatible - default behavior
unchanged.
mnpoonia
force-pushed
the
feature/hbase-vote-docker
branch
from
August 5, 2026 17:16
96722e4 to
64166df
Compare
Contributor
Author
|
@apurtell I have accommodated the review comments. 2 were not valid and all other were. Have fixed all of them |
apurtell
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends hbase_docker to support three input modes and adds unified build script for better user experience.
Changes: