Conversation
Add a Rust test that asserts build_input_rows, input_rows, and output_rows stay stable when CrossJoinExec inputs are split into multiple batches. Related to apache#25333.
rgbuilds
force-pushed
the
cursor/cross-join-metrics-tests-6895
branch
from
September 20, 2026 06:24
e12556c to
7c49814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #25333 (
CrossJoinExectest coverage only).Rationale for this change
Join metrics can be incorrect without affecting query results. Existing
CrossJoinExectests did not assertbuild_input_rowsorinput_rowsacross different input batch layouts.What changes are included in this PR?
Adds Rust test coverage that:
build_input_rows,input_rows, andoutput_rowsfor the existing single-batch case.This is a test-only change.
What is the testing strategy for this PR?
cargo fmt --check cargo test -p datafusion-physical-plan --lib joins::cross_join cargo clippy -p datafusion-physical-plan --all-targets --all-features -- -D warningsAll checks pass locally.
Are there any user-facing changes?
No.