fix(android): correct EXIF orientation for non-JPEG camera captures - #976
Open
GitToTheHub wants to merge 1 commit into
Open
fix(android): correct EXIF orientation for non-JPEG camera captures#976GitToTheHub wants to merge 1 commit into
GitToTheHub wants to merge 1 commit into
Conversation
- `MediaStore.ACTION_IMAGE_CAPTURE` always writes JPEG data into the capture file, regardless of the requested encodingType/file extension. Deriving the source mimeType from that file's extension (via `FileHelper.getMimeType`) caused PNG-named captures to be misreported as image/png, so `getScaledAndRotatedBitmap()` skipped reading the EXIF orientation and `correctOrientation` had no effect. - Use the actual JPEG mimeType for the captured source data instead, so orientation correction works regardless of the requested encodingType. Generated-By: Claude Sonnet 5
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
MediaStore.ACTION_IMAGE_CAPTUREalways writes JPEG data into the capture file, regardless of the requested encodingType/file extension. Deriving the source mimeType from that file's extension (viaFileHelper.getMimeType) caused PNG-named captures to be misreported as image/png, sogetScaledAndRotatedBitmap()skipped reading the EXIF orientation andcorrectOrientationhad no effect.Generated-By: Claude Sonnet 5
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))