Fraction.add and subtract return the reduced form when an operand is zero - #1787
Merged
Merged
Conversation
Member
|
@lenamonj Looks good, thank you, merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Sep 9, 2026
zero (#1787). - Test both operands being unreduced zeros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1784. The zero shortcuts in
addSubreturned the other operand as constructed, soZERO.add(2/4)was2/4against the Javadoc's reduced-form promise, andZERO.subtract(Integer.MIN_VALUE/2)threw although the reduced result1073741824/1fits, both noted in the #1784 review. The shortcuts now reduce before returning or negating. The new test covers both operations with zero on either side and theInteger.MIN_VALUEboundary; it fails on master and passes with the change. Defaultmvngoal green with-Ddoclint=all.mvn; that'smvnon the command line by itself.