UI: expose network ACL replacement from VPC tiers - #13794
Draft
Dogface2k wants to merge 3 commits into
Draft
Conversation
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13794 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19788 -4
============================================
Files 6368 6368
Lines 574881 574901 +20
Branches 70351 70352 +1
============================================
- Hits 112970 112946 -24
- Misses 449639 449688 +49
+ Partials 12272 12267 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@Dogface2k |
|
UI build: ✔️ |
Contributor
@weizhouapache there is now also a button in the vpc tiers overview list. I think that is fine as well. (edit: your sshot is from the tiers details page, this is extra) |
Author
|
isolating VPC tier ACL replacement state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Expose the existing
replaceNetworkACLListoperation directly from the VPC tiers overview.This is an additional UI entry point. The existing replace-ACL action on an individual tier's detail page remains unchanged.
Scope
replaceNetworkACLListAPI; no server, API, schema, or ACL-semantics changesreplaceNetworkACLListis unavailable to the current userBehaviour
The overview action opens a dedicated replacement form preselected with the tier's current ACL. The replacement flow has its own form reference, form data, validation rules, ACL list, selected ACL, target VPC and tier identifiers, and loading state. It does not reuse or mutate the create-tier form state.
showReplaceAclModalremains the modal visibility state. User cancellation is handled byhandleCloseReplaceAclModal, which hides the modal and invalidates the cancelled interaction. A validated submission hides the modal without cancelling its captured operation.Each interaction captures its VPC and tier identifiers. Closing the modal, opening another tier, or navigating to another VPC invalidates older ACL-list or validation completions, so stale asynchronous responses cannot overwrite a newer modal or the create-tier form.
A validated submission uses the identifiers and form state captured for that interaction. An older submission completing later cannot clear a newer interaction's loading state or substitute its identifiers. Successful asynchronous completion refreshes the parent VPC only when that VPC is still being viewed.
The existing create-tier ACL-loading and selection path remains unchanged.
Validation
Focused tests in
VpcTiersTab.spec.jscover:data()and resolving to the mounted form instance;aclidand capturednetworkid;The full repository UI workflow should be reviewed on the current head before merge.