CASSANDRA-21625 Column Comparison with null NPEs for Accord Transaction - #5073
Open
alanwang67 wants to merge 3 commits into
Open
CASSANDRA-21625 Column Comparison with null NPEs for Accord Transaction#5073alanwang67 wants to merge 3 commits into
alanwang67 wants to merge 3 commits into
Conversation
dcapwell
reviewed
Aug 28, 2026
| { | ||
| super(kind); | ||
| Invariants.requireArgument(KINDS.contains(kind), "Kind " + kind + " cannot be used with a value condition"); | ||
| Invariants.requireArgument(value != null, "Value conditions require a non null comparison value"); |
Contributor
There was a problem hiding this comment.
it might be best to do something like value = reference.type().santize(value) or check isNull here... that is just to handle "meaningless emptyness" (legacy concept from thrift days, but it impacts many common types like int)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following transaction NPEs, we should instead reject transactions that compare a column with null. IS NULL/IS NOT NULL should be used instead.
patch by Alan Wang;
reviewed by for CASSANDRA-21625
Co-authored-by: Name1
Co-authored-by: Name2