[CALCITE-7691] The behavior of SESSION table functions is unspecified… - #5206
Open
Dwrite wants to merge 1 commit into
Open
[CALCITE-7691] The behavior of SESSION table functions is unspecified…#5206Dwrite wants to merge 1 commit into
Dwrite wants to merge 1 commit into
Conversation
… for NULL timestamps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior of SESSION table functions is unspecified for NULL timestamps
Jira Link
CALCITE-7691
Changes Proposed
The behavior of the SESSION table function was undefined when the timestamp
column contained NULL values: SessionizationEnumerator.initialize() called
requireNonNull on the watermark column, so any row with a NULL timestamp
caused a NullPointerException at runtime instead of a well-defined result.
This is a one-line change that makes rows with a NULL timestamp be silently
dropped from the session computation, rather than throwing. This matches the
behavior of most SQL aggregate functions, which ignore NULL inputs, and
avoids changing the (currently NOT NULL) return type of the window_start
and window_end columns.
A test case has been added to stream.iq covering a SESSION query whose
input contains a mix of NULL and non-NULL timestamps.