Migrate from ujson to orjson - #2185
Open
jjardon wants to merge 1 commit into
Open
Conversation
ujson is in maintenance-only mode and its own maintainers recommend
migrating to orjson. This change replaces the dependency and updates
the single call site in _cachekey.py.
Key differences handled:
- orjson.dumps() returns bytes (so the extra .encode("utf-8") is removed)
- sort_keys=True becomes option=orjson.OPT_SORT_KEYS
- escape_forward_slashes=False is the default behaviour of orjson
jjardon
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
August 25, 2026 01:06
abderrahim
reviewed
Sep 1, 2026
|
|
||
| # This is in order to ensure we never add a `Node` to a cache key | ||
| # as ujson will try to convert objects if they have a `__json__` | ||
| # as orjson will try to convert objects if they have a `__json__` |
Contributor
There was a problem hiding this comment.
I can't see anything to this effect in orjson repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ujson is in maintenance-only mode and its own maintainers recommend migrating to orjson. This change replaces the dependency and updates the single call site in _cachekey.py.
Key differences handled:
Tested successfully at https://github.com/jjardon/buildstream-1/actions/runs/32796227859?pr=4
Fixes #2184