reduce redundant artifact, CAS, and cache-key work - #2172
Conversation
|
The failed CI jobs are all failing for the same unrelated reason.
|
#2175 Fixes this. |
PR merged, you should be able to rebase the branch for a happy CI. |
Artifact.cache() already stores the collected directory digest and never uses the recursive size calculation that follows it. Remove the dead accumulator and _get_size() call so artifact creation does not walk the output tree a second time.
fetch_directory() has already fetched the directory protos with FetchTree before enumerating required blobs. Tell required_blobs_for_directory() to reuse those local protos instead of issuing another FetchTree request, reducing remote CAS round trips.
Weak and strict cache keys both consume the same build dependency list. Materialize the generator once and reuse it so cache-key updates do not traverse the dependency graph twice while preserving the existing key inputs and ordering.
dc65f9c to
857681c
Compare
abderrahim
left a comment
abderrahim
left a comment
There was a problem hiding this comment.
LGTM, but I'd prefer @juergbi take another look
3 participants
This change removes redundant work from artifact creation, remote CAS directory fetching, and cache-key calculation:
FetchTreerequest inCASCache.fetch_directory().