[Test only] Backport #10852 (Auto RowSelection construction) to 59_maintenance - #10885
Draft
alamb wants to merge 5 commits into
Draft
[Test only] Backport #10852 (Auto RowSelection construction) to 59_maintenance#10885alamb wants to merge 5 commits into
alamb wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ReadPlanBuilder::with_predicate_options#10776Rationale for this change
Draft backport of #10852 onto
59_maintenanceso I can test the performance of that change against the 59 release line. Not intended for merge.What changes are included in this PR?
Cherry-pick of the four commits from #10852, plus two small adaptations for
59_maintenance:mask_to_selectorsimport inread_plan.rs(still used on this branch)rand::RngExt→rand::Rng(this branch pins rand 0.9)Are these changes tested?
Yes, by the tests brought over from #10852.