ci: add Windows on ARM + vcpkg pipeline - #4686
Open
lidavidm wants to merge 11 commits into
Open
Conversation
lidavidm
force-pushed
the
gh-4860
branch
2 times, most recently
from
August 13, 2026 05:08
75fad0b to
0a61f2f
Compare
Closes #4860.
There was a problem hiding this comment.
Pull request overview
Adds dedicated vcpkg CI coverage for native Windows CMake builds, including ARM64.
Changes:
- Moves existing x64 vcpkg jobs into a dedicated workflow.
- Adds Windows ARM64 release coverage and a custom vcpkg triplet.
- Avoids unsupported Go linker flags on Windows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/native-vcpkg.yml |
Defines x64 and ARM64 vcpkg CI jobs. |
.github/workflows/native-windows.yml |
Removes the relocated vcpkg job. |
c/cmake_modules/GoUtils.cmake |
Excludes Windows from ELF soname flags. |
ci/vcpkg/triplets/arm64-windows-release.cmake |
Configures ARM64 release dependencies. |
Suppressed comments (1)
.github/workflows/native-vcpkg.yml:42
- The push filter also watches the old workflow rather than this file. Consequently, a push that changes only
native-vcpkg.ymlwill not validate the updated pipeline.
- ".github/workflows/native-windows.yml"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lidavidm
changed the title
lidavidm
marked this pull request as ready for review
August 13, 2026 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4680.
Assisted-by: GPT-5.6 Sol codex@openai.com