fix(template): translate the search placeholder in the server-rendered header - #1585
Closed
culfin wants to merge 1 commit into
Closed
fix(template): translate the search placeholder in the server-rendered header#1585culfin wants to merge 1 commit into
culfin wants to merge 1 commit into
Conversation
…d header header.html writes \`placeholder="Search"\` literally. Every other string in the same file goes through \`translator\`, and the key for this one exists in all 45 language files as \`ui.header.search.placeholder\`. The result is an English word in the middle of an otherwise translated page — visible to anyone reading before the interface loads, and to search engines, which never see anything else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui/template/header.htmlwrites the placeholder literally:Every other string in that file goes through
translator, and the key for thisone already exists —
ui.header.search.placeholder, present in all 45 languagefiles under
i18n/. The React interface uses it; only the template does not.The result is one English word in the middle of an otherwise translated page.
Two audiences see it: readers, until the interface takes over, and search
engines, which see nothing else.
🤖 Generated with Claude Code