samplers: adds top-n-sigma sampler - #841
Open
daniel-j-h wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental: top n sigma sampler from https://arxiv.org/abs/2411.07641 samples logits: keeps tokens with
logit >= max(logit) - n * std(logit)masks the rest to -inf and temperature softmax samples from these candidates.Why it's an interesting sampler for ds4 and in use in a coding harness
Try it out e.g. by passing to the API
"temperature":1.5,"top_n_sigma":1; recommended0.5 < n < 2*sqrt(3).Here's how to set this up in pi.dev https://pi.dev/docs/latest/models#sampling-parameters:
We need to experiment and see how it behaves especially with the heavily quantized versions.
I've experimentig with it for a while now via ggml-org/llama.cpp#11223 and there's more context here
Confirmed working on amd strix halo; fedora needs fixes #552 pi.dev needs config #561
Disclaimer: I have used deepseek-v4-flash with pi as a tool to assist in writing this changeset.