Preserve explicit empty query string values - #1857
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve explicitly empty string query parameters instead of silently dropping them from the request URL.
Querystring._stringify_item()currently converts a primitive value to a string and then drops it whenever the serialized result is falsy. That intentionally omitsNone, but it also conflates""with absence:{"key": None}-> parameter omitted{"key": ""}-> parameter also omittedHTTP APIs can distinguish a missing parameter from an explicitly blank one (
key=), so callers currently cannot express the latter through the SDK query serializer.The same issue affects nested values and repeat/bracket array entries containing an empty string.
Fix
Make omission depend on the original value being
None, not on the truthiness of its serialized representation.Existing behavior is preserved for
None. Explicit empty strings now serialize askey=. All non-empty strings, numbers, booleans, nested mappings, and existing array formatting continue through the same serialization paths as before.Regression coverage
Adds focused tests covering:
blank=;filter[name]=;Noneentries stay omitted;Noneomission contract.The production change is confined to the query-string serializer.