Accept awaitable-returning async middleware callables - #1856
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Accept awaitable-returning async middleware callables#1856sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept function-style async middleware that is a synchronous callable returning an
Awaitable, matching the SDK's publicAsyncMiddlewareCallabletype contract.AsyncMiddlewareCallableis defined as aCallable[[APIRequest, AsyncCallNext], Awaitable[AsyncAPIResponse[Any]]]. That contract does not require the callable itself to be declared withasync def: a regular function or callable object may validly return the coroutine produced bycall_next(request).validate_async_middleware()currently rejects that shape at client construction because it requiresinspect.iscoroutinefunction(...)to be true.Fix
For function-style async middleware, validate that the entry is callable but do not require the callable itself to be a coroutine function.
Class-based
Middlewareremains strict:handle_async()must still be async. Non-callable middleware remains rejected.Regression coverage
Adds end-to-end async-client tests for:
call_next(request);