Offload sync session tools from the event loop - #1853
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent synchronous tools accepted by
SessionToolRunnerfrom blocking the async event loop.The managed-agents session runner explicitly accepts both:
BetaRunnableTool(synchronous)BetaAsyncRunnableTool(asynchronous)through
BetaAnyRunnableTool.Its shared dispatcher currently calls every tool synchronously first:
result = tool.call(input)and only afterward checks whether the result is awaitable.
For a synchronous tool, the entire tool body therefore runs on the event-loop thread. A blocking filesystem, subprocess, network, or user-defined sync tool can stall the session event stream and other async coordination.
Fix
Dispatch based on the callable shape before invoking it.
anyio.to_thread.run_sync;Regression coverage
Adds deterministic tests proving: