Validate provider access tokens before auth - #1852
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject malformed access-token values from dynamic credential providers before constructing an HTTP
Authorizationheader.AccessTokenAuthcurrently trusts the string returned byTokenCache.get_token()and immediately constructs:Authorization: Bearer <token>A custom credential provider can return an empty token or a token with surrounding whitespace. In the empty case the SDK produces
Authorization: Bearer, which can be rejected later by the HTTP stack as an invalid header value. The resulting protocol/API connection error obscures the actual problem: the credential provider returned an invalid token.Fix
Validate the token immediately before applying it to the request.
The auth adapter now requires:
Invalid provider output raises a clear
AnthropicErrorbefore any Authorization header is added.Caller-supplied static credentials retain their existing precedence.
Regression coverage
Adds sync and async tests covering invalid provider tokens, valid tokens, OAuth beta-header injection, and static Authorization bypass.