Retry ack for claimed work items - #1851
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry acknowledgment for the work item that was already claimed before polling for another item.
iter_work()andaiter_work()currently handle a transientwork.ack()failure by backing off and then continuing the outer polling loop.The current sequence is:
poll()claimswork_1;ack(work_1)fails transiently;poll()again.The original item is never acknowledged or yielded before the worker resumes polling.
Fix
Keep the claimed item in hand and retry its acknowledgment in an inner loop.
For sync and async pollers:
ack()for the samework_id;poll()occurs between attempts;Regression coverage
Adds deterministic sync and async tests where the first ack returns a transient 500 and the second succeeds.
The tests require the operation order:
poll,ack,ackand fail if a second
poll()occurs before acknowledgment succeeds.