Clean up partial skill extractions on failure - #1847
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make session-skill download and extraction transactional so failed or cancelled extraction cannot leave untracked third-party files in the agent workdir.
download_session_skills()returns the directories thatAgentToolContextlater removes during teardown. A skill directory is currently appended to that list only after_download_and_extract()succeeds.If archive streaming or extraction creates part of the destination tree and then raises, the outer loop logs the failure and continues, but the partial directory was never added to the returned cleanup list.
AgentToolContext._cleanup_skills()therefore never removes it.The temporary
.skill-*.archivefile also uses an async unlink infinallywithout shielding, so cancellation can interrupt that cleanup.Fix
Treat each skill extraction as transactional:
_download_and_extract()raises after the previous destination has been cleared, remove the destination tree before propagating the error;_download_and_extract()as well.Ordinary per-skill failures retain the existing behavior: they are logged and the downloader proceeds to the next skill, but no partial destination remains behind.
Regression coverage
Adds focused async tests verifying:
.skill-*.archivetemporary file behind.The production change is confined to Anthropic's hand-maintained skill download/extraction helper.