Preserve falsy parsed outputs - #1839
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve valid falsy structured outputs returned by messages.parse() and beta.messages.parse().
Both ParsedMessage.parsed_output and ParsedBetaMessage.parsed_output currently use a truthiness check:
if content.type == "text" and content.parsed_output:
As a result, valid parsed outputs such as False, 0, "", [], and {} are incorrectly exposed as None.
Fix
Check explicitly for None instead of truthiness:
if content.type == "text" and content.parsed_output is not None:
This preserves all valid structured-output values while continuing to return None when no parsed output is present.
The fix is applied consistently to both:
Regression coverage
Adds focused tests covering:
The regression also verifies that an earlier text block with parsed_output=None does not prevent a later valid falsy parsed value from being returned.