Handle MCP blob resources without MIME types safely - #1836
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Handle MCP blob resources without MIME types safely#1836sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent MCP binary blob resources with no MIME type from being treated as UTF-8 text.
mcp_resource_to_content()currently considersmime_type=Nonesupported for every MCP resource. For aBlobResourceContents, that causes arbitrary binary bytes to be base64-decoded and then decoded as UTF-8, which can raiseUnicodeDecodeError. It can also cause an unknown binary blob to be selected ahead of a later supported resource in the sameReadResourceResult.Fix
TextResourceContents;UnsupportedMCPValueErrorfor a directly embedded no-MIME blob instead of leaking a Unicode decoding exception;text/*, PDF, and supported image behavior;<missing>in the unsupported-resource diagnostic when MIME metadata is absent.Regression coverage
Adds offline tests covering:
text/plainblob.The change is confined to the hand-maintained MCP conversion helper and its tests.