fix(aria/combobox): empty aria-controls when the popup widget has no id - #33635
Open
lazerg wants to merge 2 commits into
Open
fix(aria/combobox): empty aria-controls when the popup widget has no id#33635lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
angular-robot
Bot
added
area: aria/combobox
area: docs
lazerg
force-pushed
the
fix/issue-70082-combobox-empty-aria-controls
branch
from
August 5, 2026 08:32
1cef0e3 to
70a1084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngComboboxWidgetreads its ID off the host element, so a popup whose widget doesn't set one (for example the dialog popup in the docs, where the widget is a plaindiv) leaves the combobox witharia-controls="", which Axe flags. The same happened when the ID came from a host binding such asngListbox, since it isn't on the element yet when the widget reads it.The widget now generates an ID after the first render if the element still doesn't have one, and re-reads the ID at that point so binding-provided ones are picked up.
Fixes #33640.