Skip to content

fix(deps): retain TypeScript 6 compatibility - #107

Closed
albert20260301 wants to merge 1 commit into
altertable-ai:dependabot/bun/cli/cli-dependencies-7101ef38b0from
albert20260301:fix/pr-105-typescript-compat
Closed

albert20260301 wants to merge 1 commit into
altertable-ai:dependabot/bun/cli/cli-dependencies-7101ef38b0from
albert20260301:fix/pr-105-typescript-compat

Conversation

@albert20260301

Copy link
Copy Markdown
Contributor

Summary

Why

openapi-typescript@7.13.0 declares a TypeScript ^5.x peer range and its generated-artifact check crashes under TypeScript 7 (ts.factory.createKeywordTypeNode is undefined). Keeping the existing TypeScript 6 toolchain makes the dependency batch CI-compatible without changing generated sources.

Validation

  • bun run typecheck
  • bun run lint
  • bun run format:check
  • bun run generate:check
  • bun test exercised 672 tests; 668 passed. The four failures are host-only because this environment has Bun 1.3.0 while the repository's release tests explicitly require its pinned Bun 1.4.0 toolchain. GitHub CI runs Bun 1.4.0.

@albert20260301

Copy link
Copy Markdown
Contributor Author

@francoischalifour could you review this stacked compatibility fix?

I picked you because recent history on cli/package.json and cli/bun.lock is primarily yours. This PR retains TypeScript 6.0.3 so Dependabot PR #105 avoids the openapi-typescript@7.13.0 / TypeScript 7 factory-API breakage. Typecheck, lint, formatting, and generated-artifact verification pass locally. GitHub CI does not start because this PR targets Dependabot's branch and the repository test workflows only trigger for PRs targeting main; the remaining release tests need the repo-pinned Bun 1.4.0. The review focus is whether that validation is sufficient to merge #107 before #105.

@albert20260301

Copy link
Copy Markdown
Contributor Author

@francoischalifour following up: CI remains green, with no requested changes or merge conflict. Could you review the stacked-TypeScript-6-compatibility when you have capacity?

@dependabot
dependabot Bot deleted the branch altertable-ai:dependabot/bun/cli/cli-dependencies-7101ef38b0 September 16, 2026 19:06
@dependabot dependabot Bot closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant