Fix CI compatibility after the Vitest 5 upgrade - #4906
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main fails during dependency installation after the Vitest 5 upgrade because Vite 8's esbuild peer conflicts with the version used by Alpine's build script. Select the supported Vite 7 line and regenerate the lockfile, preserving the existing package build tooling.
Run CI on Node 24, which satisfies Vitest 5's engine requirement and matches the release workflows, and install with
npm ci. Limit Vitest discovery totests/vitestso it does not execute the Cypress specs.The real-browser dwell tests now scroll slightly beyond the half-visible threshold. At the exact boundary, the local browser reports
0.4999999701976776, preventing the dwell timer from starting. The tests still exercise threshold exit, re-entry, and once-only behavior using the native IntersectionObserver.The popover focus-away test explicitly focuses the visible panel link before pressing Tab, establishing its intended precondition without relying on asynchronous autofocus. Its five-attempt retry setting is removed.
Validation: reproduced the original install failure; fresh
npm ciand package builds pass; full Cypress suite passes 623 tests with 26 existing skips; Vitest passes 204 tests with one existing skip. Both GitHub Actions runs pass ond9a3a32e.