Fix(CspParser): accept reserved words as property/method names and object keys - #4905
Merged
calebporzio merged 2 commits intoSep 14, 2026
Conversation
…ected as property/method names
…ject literal keys (IdentifierName, not just Identifier)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reserved words like
delete,new,true,null,undefined, etc. couldn't be used as property or method names after a.or as object literal keys in the CSP build, even though this is valid JavaScript. This broke Livewire'swire:click="delete"directive, which compiles down tox-on:click="$wire.delete()".Real ECMAScript distinguishes Identifier (variable references, reserved words forbidden) from IdentifierName (property names, reserved words allowed). The CSP tokenizer already classifies its own reserved words (
KEYWORD,BOOLEAN,NULL,UNDEFINED) into their own token types, and they should all be usable as property names just like ECMAScript'sIdentifierNameallows for its own reserved words. Member access (.foo) and object literal keys only acceptedIDENTIFIER, rejecting the rest.Added
checkIdentifierName()/consumeIdentifierName()to the parser to accept any identifier-name-eligible token and resolve it to its string form. The tokenizer stays context-free, the fix lives entirely in the parser.Variable references (
parsePrimary) are untouched: reserved words still can't be used as bare identifiers, matching real JS.Note
While auditing this, I also noticed object literals don't accept a
NUMBERkey ({ 5: 1 }, valid in real JS viaLiteralPropertyName). I haven't hit this in a real-world case, not sure it's worth a separate issue, but it might come up eventually i suppose.Test Plan
.isn't followed by a valid identifier namecsp-parser.spec.jsFixes #4904