Adding support for eslint 9 - #3244
Conversation
|
Giving it a try @ljharb 🙏 |
This comment was marked as resolved.
This comment was marked as resolved.
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint-find-rules": "^4.1.0", | ||
| "eslint": "^7.32.0 || ^8.2.0 || ^9.0.0", | ||
| "eslint-find-rules": "^5.0.0", |
There was a problem hiding this comment.
eslint-find-rules v5 doesn't support eslint 7, so this will have to be ^4.1.0 || ^5.0.0
| "dependencies": { | ||
| "confusing-browser-globals": "^1.0.11" | ||
| "confusing-browser-globals": "^1.0.11", | ||
| "globals": "^15.14.0" |
There was a problem hiding this comment.
why is globals needed? eslint ships with that package and we should be using the same version it uses.
There was a problem hiding this comment.
@ljharb without it being in the package.json we fail the no extraneous dependencies check due to the import. So I put it as a peer dependency. Otherwise I could either disable the rule or use the raw values instead of from globals. Let me know if you want a different change
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint-find-rules": "^4.1.0", | ||
| "eslint": "^7.32.0 || ^8.2.0 || ^9.0.0", | ||
| "eslint-find-rules": "^5.0.0", |
|
@ljharb let me know your thoughts with the changes |
|
@ljharb are the issues with the previous iteration resolved? |
3d1cb85 to
700d1a5
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
|
thank you @daltino hopefully it can be approved soon 🙏 |
|
@ljharb any way you can take a look again? |
|
eslint 9 is about to hit EOL |
|
@christianvuerings could you take a look at this? |
4 participants
Giving my attempt at eslint 9 support 😅