Raid v2 improvments

[maximeroucher]

Description

Summary

Updating Raid to match the first points for data security

Changes Made

• Adding consent field to the security file
• Adding read_medical_data permission gating the zip download (now only source of security file read)
• Logging when a zip download is attempted
• Adding course responsible as emergency contact into the security file, as the Raid requested

Additional Notes

First step toward a better security data handling.

Classification

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
• 🔧 Infra CI/CD (changes to configs of workflows)
• 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
• 😶‍🌫️ No impact for the end-users

Impact & Scope

• Core functionality changes
• Single module changes
• Multiple modules changes
• Database migrations required
• Other: ...

Testing

• 1. Tested this locally
• 2. Added/modified tests that pass the CI (or tested in a downstream fork)
• 3. Tested in a deployed pre-prod
• 0. Untestable (exceptionally), will be tested in prod directly

Documentation

• Updated the docs accordingly :
• " Docstrings
• # Inline comments
• No documentation needed

[Marc-Andrieu]

Looks promising! That's a clean start about the medical data issue

[codecov]

Codecov Report

❌ Patch coverage is 64.93506% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.83%. Comparing base (53e5e7e) to head (bd32789).

Files with missing lines	Patch %	Lines
app/modules/raid/endpoints_raid.py	51.19%	41 Missing ⚠️
app/modules/raid/utils/utils_raid.py	52.83%	25 Missing ⚠️
app/modules/raid/cruds_raid.py	56.25%	14 Missing ⚠️
app/modules/raid/dependencies_raid.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   84.96%   84.83%   -0.13%     
==========================================
  Files         220      220              
  Lines       16400    16553     +153     
==========================================
+ Hits        13934    14043     +109     
- Misses       2466     2510      +44     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Daihecyy]

Possible to split PR ?
consent_given and course_responsible have nothing to do with each other, comments will get muddled

[maximeroucher]

Possible to split PR ? consent_given and course_responsible have nothing to do with each other, comments will get muddled

Given the time constraint and the time taken to review and merge a PR, I decided to put all the changes in one. I acknowledge that it will be a bit harder to read, that's why I ensure to produce really thin commit to allow a good review