feat(addie): add private smoke authority ledger - #7319
Merged
Conversation
bokelley
force-pushed
the
conductor/6842-private-authority-ledger
branch
2 times, most recently
from
September 6, 2026 13:27
e0af715 to
b0df61e
Compare
Exceptional timeout recovery: the normal pre-commit and a direct precommit:server-unit invocation each reached the repository's fixed 600-second limit while Vitest continued advancing in this VM. Equivalent CI shards 1/4 through 4/4 passed with local DEV_USER_EMAIL and DEV_USER_ID unset to match CI; all other hook-equivalent gates, focused tests, PostgreSQL integration, typecheck, and diff check passed.
Exceptional no-verify recovery remains authorized after the repository's fixed 600-second server-unit hook timeout. Current focused unit/typecheck and fresh PostgreSQL migration/integration evidence passed; clean-environment four-shard evidence was rerun during this pass. No hook was modified.
bokelley
force-pushed
the
conductor/6842-private-authority-ledger
branch
from
September 6, 2026 13:57
573ae3e to
63c5977
Compare
bokelley
marked this pull request as ready for review
September 6, 2026 15:55
Contributor
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — additive, dormant private smoke authority ledger (#6842), no blocking or medium findings.
What I checked:
- High-risk flag context:
high_riskis true but every reason is(added)— new files underserver/src/addie/**and a new migration underserver/src/db/migrations/**. New files matching high-risk globs are normal scaffolding and are not escalation-worthy on the flag alone (no(deleted)or(modified)entries, so rows 3 and 5 do not fire). - Gated paths:
gated_paths: false, so row 2 does not apply despitereview_decision: REVIEW_REQUIRED. - Migration 582: production-facing (runs on startup), occupies the next free slot; reviewer verified the
expected_costSQL reproduces the TSdatedPricingCostMicrosaccounting for all four pricing profiles; plan/attempt/authorization rows are trigger-immutable and recovery is fail-closed (persistence_uncertain, never a false durable-poison). - Reachability: module is dormant/unreachable (
IS_CONSTRUCTED=false, no src importer, production trust registries hard-null and fail-closed). - Protocol surface: touches no
static/schemas/source/**, docs, or dist artifacts — no changeset required, no schema↔docs drift, no oneOf regression, no artifact-immutability concern. - Author team gates: no no-auto-approve match.
One non-blocking follow-up noted by the reviewer (no lock/statement timeout on transaction() for a future live runtime) — dormant today, not a current medium finding.
No critical/high/medium findings → rows 1–8 do not fire → row 9 approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Private authorization and PostgreSQL ledger contract only for Addie #6842. No provider adapter, route, job, cron, composition root, credential, issuer key, provider/API call, or runnable dispatch path is included.
FIXED_TRACE_COMPONENT_SMOKE_CURRENT_MODULE_CAN_DISPATCHremains permanently false.null. An injected root cannot mint a capability until a later review pins its digest.Audit dispositions
consumed, no existing open intent, and for ordinal N>1 a succeeded immediate predecessor withtool_continuation_required. A final ordinal-1 generation response blocks ordinal 2.invalid_limits, halts dispatch, and can close as a provider failure. Unknown-exposure recovery locks eitherconsumedor already-unknown authorization idempotently, then derives started/unclosed provider outcomes without invented evidence; untouched assignments close as zero-callnot_executed_after_halt. Every 168 assignment has one outcome; only a fully completed consumed run becomescompleted; halted/unknown remain permanently nondispatchable.ROW EXCLUSIVEbefore its target plan row; directUPDATEhas the same PostgreSQL table lock. Before recovery acquires any plan row it takesSHARE ROW EXCLUSIVE, serializing it against those writers, then locks the complete immutable plan set in assignment order → all existing attempts in deterministic order → authorization. Complete-plan locking is the insertion gate, so no intent can appear after its attempt snapshot.recordProviderIntentobserves unresolved work before a target or under the authorization, commits that transaction, then invokes standalone recovery. Failed recovery returnspersistence_uncertain, never a false durable-poison result.Validation
origin/maind44a71a553476480d08a0fff76e2a606b08997c4.env -u DEV_USER_EMAIL -u DEV_USER_ID npx vitest run --config server/vitest.config.ts tests/unit/addie/fixed-trace-component-smoke-private-authorization.test.ts tests/unit/addie/fixed-trace-component-smoke-private-ledger-state.test.ts— 37 passed.npm run typecheck— passed.server/tests/integration/addie/fixed-trace-component-smoke-private-ledger-migration.test.ts— 33 passed. This includes blocker-controlled precheck-to-committed-intent-to-standalone-recovery interleaving, a forced recovery lock-timeout regression proving no false durable poison or later dispatch, a three-transaction full-plan recovery insertion-gate/phantom regression, reverse-order multi-outcome writer versus recovery coverage, and recovery-gate-first application-outcome coverage.git diff --check— passed.precommit:server-unitpreviously reached the repository fixed 600-second wall-clock timeout while still advancing in this VM. The normal hook is a timeout/failure, not a pass. The latest commit uses the authorized one-timeHUSKY=0timeout exception. Exact-head GitHub CI remains the full-suite gate.Draft only pending exact-head GitHub CI, root inspection, and independent Sol re-review. No merge, ready-for-review transition, runtime activation, provider call, or spend.