fix(ci): retire superseded Ladon change requests - #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHANGES_REQUESTEDreview only after Ladon approves the current PR headWhy
PR #1134 had every required CI check green and a Ladon approval on its final head, but GitHub kept Ladon’s earlier
CHANGES_REQUESTEDreview active. That left the PR blocked until an admin merge. GitHub only auto-dismisses stale approvals; it does not retire an earlier change request when the same App later approves.Verification
node --test scripts/retire-superseded-ladon-reviews.test.cjsnode --check scripts/retire-superseded-ladon-reviews.cjsactionlint1.7.7 onai-review.ymlandci.yml5123075139, the superseded Ladon change requestSecurity
The helper runs from the trusted base-SHA checkout under
pull_request_target, uses the existing short-lived Secretariat App token, and can only dismiss older change requests authored by that same App after its latest review approves the exact current head SHA.