fix(csv-stringify): avoid Node globals in browser types - #501
Open
be-student wants to merge 1 commit into
Open
Conversation
Member
|
I hesitate. Not being a TS expert, I understand that importing node types definition is not necessary in a browser environment. At the same time, no one ever complained until now which make me think it is not blocking and the proposition increase the complexity of the build system when I wish to simplify it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476.
Keep the Node type reference in Node declarations, but remove it from the generated browser ESM declaration. A browser-only TypeScript fixture prevents ambient Node globals from returning.
Tests: csv-stringify type checks; browser fixture; 209 tests on Node 24; ESLint and Prettier.