fix(sdk): tighten percentageString validator and guard BigInt pct parsing - #275
Open
devtechedge wants to merge 1 commit into
Open
fix(sdk): tighten percentageString validator and guard BigInt pct parsing#275devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
devtechedge
requested review from
amateima,
ashwinrava,
dohaki,
gsteenkamp89,
melisaguevara,
mrice32 and
nicholaspai
as code owners
September 11, 2026 02:09
|
@devtechedge is attempting to deploy a commit to the UMA Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 039a9ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266
Summary of Changes
percentageStringregex inpackages/sdk/src/api/validators.tsfrom/^\d+(\.\d+)?$/to/^\d+$/so percentage strings with decimal points are caught and rejected at the validation boundary rather than crashing downstream consumers.BigIntconversion: Inpackages/sdk/src/actions/getSuggestedFees.ts, wrapped pct assignments inparseSuggestedFeeswith safe parsing (toBigIntPct) so unexpected float strings will not throw an uncaughtSyntaxError: Cannot convert ... to a BigIntat runtime.@across-protocol/app-sdkpatch changeset via.changeset/fix-suggested-fees-pct-bigint.md.test/unit/api/suggested-fees.test.tsverifying decimal rejection bypercentageStringand safe conversion inparseSuggestedFees.