Skip to content

fix(server): show falsey defaults in CLI help #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abetlen merged 2 commits into from
Aug 17, 2026
+2 −1
Merged

fix(server): show falsey defaults in CLI help #2355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a131d4a
fix(server): show falsey defaults in CLI help
Aug 3, 2026
684e3b6
test(server): remove CLI regression test
abetlen Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- feat: update llama.cpp to ggml-org/llama.cpp@4df29be4f
- fix(example): retain recurrent state for server MTP rollback
- feat: update llama.cpp to ggml-org/llama.cpp@adb55e514
- fix(server): show falsey defaults in CLI help by @cupkk in #2355

## [0.3.34]

Expand Down
2 changes: 1 addition & 1 deletion llama_cpp/server/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def add_args_from_model(parser: argparse.ArgumentParser, model: Type[BaseModel])

for name, field in model.model_fields.items():
description = field.description
if field.default and description and not field.is_required():
if description and not field.is_required() and field.default is not None:
description += f" (default: {field.default})"
base_type = (
_get_base_type(field.annotation) if field.annotation is not None else str
Expand Down