fix(config): point the cache_ttl error at the config file, not --refresh - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex review finding (Medium) on the pending v0.10.0 delta.
The non-positive
cache_ttlerror suggested--refresh, but:status,revokeandfavorites addhave no--refreshflag;config.Loadrejects the value before any command-level flag is read, so--refreshcould not help even where it exists.The message now names the actual remedy — remove the setting to fall back to the default — and interpolates
DefaultCacheTTLrather than hardcoding4h.Also updated the CLAUDE.md rationale and the v0.10.0 CHANGELOG line, both of which advertised
--refresh.Test expectation updated first (watched it fail), then the message. Subtest names renamed off
--refresh.Verified: gofmt clean, build,
-race,-shuffle=on, integration — all rc=0.