fix: defer AgentCard resolution to prevent eager startup failures - #1058
Open
kabir wants to merge 1 commit into
Open
fix: defer AgentCard resolution to prevent eager startup failures#1058kabir wants to merge 1 commit into
kabir wants to merge 1 commit into
Conversation
1 task
…aproject#1033) All three handler implementations (gRPC, JSON-RPC, REST) now store Instance<AgentCard> and resolve lazily on first access instead of eagerly in the constructor. This prevents startup failures when the AgentCard producer depends on the HTTP server's bound address, which is not yet available during gRPC service construction at RUNTIME_INIT. Transport validation is also deferred to first use via an AtomicBoolean guard, consistent with the existing pattern in GrpcHandler. This fixes a2aproject#1033 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kabir Khan <kkhan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three handler implementations (gRPC, JSON-RPC, REST) now store Instance and resolve lazily on first access instead of eagerly in the constructor. This prevents startup failures when the AgentCard producer depends on the HTTP server's bound address, which is not yet available during gRPC service construction at RUNTIME_INIT.
Transport validation is also deferred to first use via an AtomicBoolean guard, consistent with the existing pattern in GrpcHandler.
This fixes #1033