Fixes #5811: Unit Auto Reclaim/Heal/Assist no longer leaves ghost idle cons - #5818
Open
Petronous wants to merge 3 commits into
Open
Fixes #5811: Unit Auto Reclaim/Heal/Assist no longer leaves ghost idle cons#5818Petronous wants to merge 3 commits into
Petronous wants to merge 3 commits into
Conversation
…ghost idle cons. Changed the widget to not issue a stop command if the unit just died.
Member
|
What if another widget gives a stop command, or even a player for a con with longer death animation? Core selector should probably be the one to notice that it's a dead unit receiving an order and not count it |
Author
|
Yeah, it's probably the better option. I suppose I was reluctant to jump straight into editing a core widget. Is checking |
Member
|
Sounds like it should be. |
added 2 commits
August 26, 2026 19:08
… leaves ghost idle cons." This reverts commit f9acc72. The ghost idle con prevention will be implemented in the core selector widget.
gui_chill_core_selector.lua now uses `Spring.GetUnitIsDead(...) == false` in `widget:UnitIdle(...)` to check if unit is really alive.
Author
|
I could also put the same check into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the widget to not issue a stop command if the unit just died (proposed solution b in my issue).Frankly I am not sure if we ever want it to issue a stop command.The core selector widget now checks whether the unit in UnitIdle is really alive before setting its IdleCons entry to true.
I tested the change and it actually does fix the issue, idle con count stays correct. I have not done exhaustive testing with other widgets, but with such a small change it should hopefully not be necessary.