Plugins: Use is_plugin_active() for the edit warning in the Plugin Editor - #13621
bishalsthadev wants to merge 1 commit into
Conversation
…itor. The "Making changes to active plugins is not recommended" warning used a raw in_array() check against the active_plugins option, which doesn't account for network-activated plugins. The page heading a few lines above already uses is_plugin_active() correctly, so use the same helper here to keep the two checks consistent.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Fixes https://core.trac.wordpress.org/ticket/66133
wp-admin/plugin-editor.php checks whether a plugin is active two different
ways on the same page. The heading correctly uses is_plugin_active(),
which accounts for network-activated plugins. The "Making changes to
active plugins is not recommended" warning further down instead used a
raw in_array() check against the active_plugins option, which only
covers site-level activation.
For a network-activated plugin this means the heading says "(active)"
but the safety warning never appears. This swaps in is_plugin_active()
for the warning check too, matching the heading logic.
Same root-cause class as #66129, different call site.