Skip to content

Plugins: Fix wp_edit_theme_plugin_file() to detect network-active plugins #13620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bishalsthadev wants to merge 1 commit into
base: trunk
Choose a base branch
from
+46 −5
Open

Plugins: Fix wp_edit_theme_plugin_file() to detect network-active plugins #13620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/wp-admin/includes/file.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,11 +425,7 @@ function wp_edit_theme_plugin_file( $args ) {

$real_file = WP_PLUGIN_DIR . '/' . $file;

$is_active = in_array(
$plugin,
(array) get_option( 'active_plugins', array() ),
true
);
$is_active = is_plugin_active( $plugin );

} elseif ( ! empty( $args['theme'] ) ) {
$stylesheet = $args['theme'];
Expand Down
45 changes: 45 additions & 0 deletions tests/phpunit/tests/admin/includesFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,4 +463,49 @@ function () {
'.tmp',
);
}

/**
* @ticket 66129
* @group multisite
* @group ms-required
*/
public function test_wp_edit_theme_plugin_file_runs_loopback_check_for_network_active_plugin() {
$user_id = self::factory()->user->create();
grant_super_admin( $user_id );
wp_set_current_user( $user_id );

$plugin = 'hello.php';
activate_plugin( $plugin, '', true );

@westonruter westonruter Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
activate_plugin( $plugin, '', true );
$this->assertNull( activate_plugin( $plugin, '', true ) );


$loopback_requested = false;
add_filter(
'pre_http_request',
function ( $preempt, $parsed_args, $url ) use ( &$loopback_requested ) {

@westonruter westonruter Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function ( $preempt, $parsed_args, $url ) use ( &$loopback_requested ) {
static function ( $preempt, array $parsed_args, string $url ) use ( &$loopback_requested ) {

if ( str_contains( $url, 'wp_scrape_key' ) ) {
$loopback_requested = true;
return array(
'body' => '',
'response' => array( 'code' => 200 ),
);
}
return $preempt;
},
10,
3
);

wp_edit_theme_plugin_file(
array(
'plugin' => $plugin,
'file' => $plugin,
'newcontent' => file_get_contents( WP_PLUGIN_DIR . '/' . $plugin ),
'nonce' => wp_create_nonce( 'edit-plugin_' . $plugin ),
)
);
Comment on lines +497 to +504

@westonruter westonruter Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this assert that the return value is true as well?


deactivate_plugins( $plugin );
revoke_super_admin( $user_id );

Comment on lines +506 to +508

@westonruter westonruter Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be needed. The they are automatically cleaned up.

Suggested change
deactivate_plugins( $plugin );
revoke_super_admin( $user_id );

$this->assertTrue( $loopback_requested, 'Editing a network-active plugin file should trigger the fatal-error loopback check.' );
}
}
Loading