Remove INET_ATON WordPress dependency - #485
Merged
Merged
Conversation
Use native PHP integer handling for the SQLite callback and cover the standalone Composer driver query with a regression test.
JanJakes
marked this pull request as ready for review
August 11, 2026 15:22
Member
Author
|
This literally inlines what WP does, so I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the driver's dependency on WordPress's
absint()helper inINET_ATON(). The replacement uses native PHP logic, allowing the Composer package to run in standalone PHP applications.A regression test covers the function through the public PDO-compatible API. The package test suite and coding-standards check pass.
Why
The standalone Composer package autoloads the driver outside WordPress. Calling
INET_ATON()previously failed becauseabsint()is not available in standalone PHP applications.