feat: correlate download diagnostics with node GETs - #185
Open
dirvine wants to merge 5 commits into
Open
Conversation
chore(release): promote rc-2026.7.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_idandlocal_peer_idfields to download diagnosticsThis allows an exact join from the client record to node-side
get_rpctelemetry using:request_id= nodetail.request_idlocal_peer_id= nodetail.source_peerchunk_addressand request time windowNo protocol change is required: the existing chunk GET already carries the request ID.
Verification
cargo test -p ant-core --lib— 443 passedcargo check -p ant-corecargo check --workspace --all-featurescargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkcargo zigbuild --release -p ant-cli --target x86_64-unknown-linux-gnuTwo independent final-diff reviews returned APPROVE, with no critical or important findings.
Behaviour notes
request_idandlocal_peer_idasnull, because they do not represent an individual peer request.Linear: V2-903