refactor(wbfy): remove obsolete migration paths - #1269
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly streamlines the wbfy codebase by removing obsolete migration paths and legacy configuration logic. By enforcing a canonical repository structure, the changes reduce the maintenance burden of supporting multiple legacy file formats and migration scenarios. Future deviations from these standards are now intended to be handled manually by repository owners rather than automatically by wbfy. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Old paths fade away, Code cleaned of the ghosts of past, Standard rules remain. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly simplifies the wbfy utility by removing extensive legacy migration, fallback, and compatibility logic across multiple configuration generators (such as Gemini, Lefthook, Renovate, and package.json), strictly aligning with the rule to support only a single canonical format. Feedback on the changes highlights a potential runtime error in the simplified Renovate configuration generator, where the extends property might be parsed as a string instead of an array, causing a crash when array methods are called.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
…tinstall runners Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
…l runner check Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Customer Summary
mainand is identical.docs/expected-repository-rules.mdso operators know what to fix by hand.Technical Summary
cloudflareEnv,testDirectory,typeDefinition,geminiSettings,lintstagedrc, husky cleanup inlefthook,.gemini/config.ymlmerging, Renovate config consolidation/deletion, obsolete preset pruning, badge legacy-form matching,--bunscript stripping, prettier/lint-staged/husky dependency removal, legacy workflow secret/parameter rewrites, legacy label deletion, and tsconfignode10cleanup on the standard path.wb db/wb prismascripts, andwb gen-codesegments are matched only in their generatedbun …spelling;getWorkerTypesScriptErrorrejects non-canonicalwb gen-codespellings and, when a gen-code pipeline exists, apostinstallrunning a package script through anything other thanbun run <script>(which would otherwise get a second generation appended)..env.cloudflareat any depth (queried once from the repository root with-c core.quotePath=false) fails the run with a rotation instruction; a non-array or obsolete-preset Renovateextendsand a non-canonical.gemini/config.ymlskip generation with a warning.generateMiseTomlrequires an exact Bun pin ≥ 1.4 and skips the file otherwise; a repository without a Bun pin (a fresh template) is pinned to the Bun version running wbfy, which the startup guard already validated..prettierignoreis generated only for Java repositories and never deleted automatically.Why
Testing
bun run verifybun test test/unitinpackages/wbfy(327 pass)package.json+src/index.ts) with this branch and withmain; the generated trees are identical except the wbfy version badge. Also ran it with an unresolvablemiseonPATHto confirmmise.tomlis still generated with the running Bun version..env.cloudflare,postinstallvariants (bun gen-code,bunx run gen-code,bun --bun run gen-code,bun run gen-code, andbun setupwithout a gen-code pipeline), a scalar Renovateextends, and an obsoletewillbooster-configspreset to confirm each rejection, warning, or pass-through.