Conversation
Applied @willbooster/wbfy v19.2.0.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aligns the repository with current WillBooster standards. It enhances AI agent instructions, streamlines the bun.lock normalization process into a reusable script, and performs necessary dependency maintenance to keep the project up to date. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Lock files now clean, Rules for agents clearly set, Codebase is boosted. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request extracts the inline bun lockfile normalization logic from lefthook.yml into a dedicated shell script, .lefthook/normalize-bun-lockfile.sh, and integrates it into the package.json prepare script. It also updates project guidelines in several markdown files to recommend using zod for object validation and to only describe final snapshots in explanatory text, alongside bumping build-ts and other dependencies. The feedback suggests simplifying the new shell script by removing a redundant file copy operation and using cat to overwrite the file.
| cp -p "$file" "$normalized" | ||
| sed -E 's#(", )"https://npm\.flatt\.tech/[^"]*"#\1""#g' "$file" > "$normalized" | ||
| if ! cmp -s "$file" "$normalized"; then | ||
| mv "$normalized" "$file" |
There was a problem hiding this comment.
The cp -p command is redundant here because sed immediately overwrites the $normalized file. We can simplify this and avoid copying the file twice by removing cp -p and using cat to write the normalized content back to $file. This naturally preserves the original file's permissions, ownership, and any hard/symlinks without needing to copy them to the temp file first.
| cp -p "$file" "$normalized" | |
| sed -E 's#(", )"https://npm\.flatt\.tech/[^"]*"#\1""#g' "$file" > "$normalized" | |
| if ! cmp -s "$file" "$normalized"; then | |
| mv "$normalized" "$file" | |
| sed -E 's#(", )"https://npm\.flatt\.tech/[^"]*"#\1""#g' "$file" > "$normalized" | |
| if ! cmp -s "$file" "$normalized"; then | |
| cat "$normalized" > "$file" |
References
- Simplify code as much as possible to eliminate redundancy. (link)
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Customer Summary
Technical Summary
Why
Testing
bun run verify-fullsuccessfully.