Skip to content

chore: willboosterify this repo - #224

Merged
exKAZUu merged 1 commit into
mainfrom
wbfy
Aug 22, 2026
Merged

chore: willboosterify this repo#224
exKAZUu merged 1 commit into
mainfrom
wbfy

Conversation

@exKAZUu

@exKAZUu exKAZUu commented Aug 22, 2026

Copy link
Copy Markdown
Member

No description provided.

Applied @willbooster/wbfy v19.1.3.
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a maintenance update to standardize tooling and documentation across the repository. It centralizes lockfile normalization logic, refines AI agent behavior guidelines to ensure clearer documentation, and updates critical build dependencies to maintain project health.

Highlights

  • Tooling Refactor: Extracted the lockfile normalization logic into a dedicated shell script to improve maintainability and reuse.
  • Documentation Guidelines: Added a new rule to AI agent instructions requiring descriptions to focus exclusively on the final state of the code.
  • Dependency Updates: Updated build-ts and various core dependencies, including oxc-parser and rolldown, to their latest versions.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


The versions climb higher today, / With lockfiles now kept in their way. / The scripts are all clean, / The code is now seen, / In the final and finished display.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts the inline bun.lock normalization logic from lefthook.yml into a dedicated shell script (.lefthook/normalize-bun-lockfile.sh), integrates it into the prepare lifecycle script in package.json, updates several project dependencies, and adds a documentation rule regarding explanatory text. Feedback on the new shell script suggests placing temporary files in the .tmp directory to comply with repository rules and simplifying the file-writing logic to eliminate redundant copy operations.

Comment on lines +8 to +20
normalized=""
trap '[[ -z "$normalized" ]] || rm -f "$normalized"' EXIT
for file in "$@"; do
[[ -f "$file" ]] || continue
normalized="$(mktemp "$file.wbfy-normalizing.XXXXXX")"
cp -p "$file" "$normalized"
sed -E 's#(", )"https://npm\.flatt\.tech/[^"]*"#\1""#g' "$file" > "$normalized"
if ! cmp -s "$file" "$normalized"; then
mv "$normalized" "$file"
echo "Removed Takumi Guard proxy URLs from $file so the lockfile stays registry-agnostic."
fi
rm -f "$normalized"
normalized=""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Improvement Opportunity: Temporary File Location & Permissions Preservation

  1. Temporary File Location: According to the repository rules, temporary files should be placed in .tmp rather than the repository root. Creating them in the repository root can pollute the working directory and trigger file watchers.
  2. Redundant Copy & Permissions Preservation: The cp -p on line 13 is redundant because the subsequent sed redirection (> "$normalized") overwrites the file. Instead of copying and moving, we can write the sed output to a temp file in .tmp and then use cat "$normalized" > "$file" to update the original file. This preserves the original file's permissions, ownership, and inode without needing cp -p or mv.
Suggested change
normalized=""
trap '[[ -z "$normalized" ]] || rm -f "$normalized"' EXIT
for file in "$@"; do
[[ -f "$file" ]] || continue
normalized="$(mktemp "$file.wbfy-normalizing.XXXXXX")"
cp -p "$file" "$normalized"
sed -E 's#(", )"https://npm\.flatt\.tech/[^"]*"#\1""#g' "$file" > "$normalized"
if ! cmp -s "$file" "$normalized"; then
mv "$normalized" "$file"
echo "Removed Takumi Guard proxy URLs from $file so the lockfile stays registry-agnostic."
fi
rm -f "$normalized"
normalized=""
mkdir -p .tmp
normalized=""
trap '[[ -z "$normalized" ]] || rm -f "$normalized"' EXIT
for file in "$@"; do
[[ -f "$file" ]] || continue
normalized="$(mktemp .tmp/wbfy-normalizing.XXXXXX)"
sed -E 's#(", )"https://npm\.flatt\.tech/[^"]*"#\1""#g' "$file" > "$normalized"
if ! cmp -s "$file" "$normalized"; then
cat "$normalized" > "$file"
echo "Removed Takumi Guard proxy URLs from $file so the lockfile stays registry-agnostic."
fi
rm -f "$normalized"
normalized=""
done
References
  1. Simplify code as much as possible to eliminate redundancy. (link)

@exKAZUu
exKAZUu merged commit 598a475 into main Aug 22, 2026
6 checks passed
@exKAZUu
exKAZUu deleted the wbfy branch August 22, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant