SLOP-319: bump dependencies to clear 4 critical + 2 high prod vulnerabilities - #2
Open
tosfos wants to merge 1 commit into
Open
SLOP-319: bump dependencies to clear 4 critical + 2 high prod vulnerabilities#2tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…bilities npm audit --omit=dev reported 11 vulnerabilities (4 critical) rooted in nodemw 0.17 depending on the abandoned request package: request SSRF, form-data CRLF injection / unsafe boundary, json-schema + jsprim prototype pollution, qs and underscore DoS chains. Mirrors fixes upstream macbre/wiki-evolution already shipped: - nodemw ^0.17.0 -> ^0.27.0 (request -> maintained @cypress/request@^4) - async ^3.2.1 -> ^3.2.6 - color ^4.0.1 -> ^5.0.3 + require(color).default (upstream 5aa1fc2) - mocha ^10 -> ^11.1.0 - overrides: underscore ^1.13.8 clears residual GHSA-qpx9-hpmf-5gmw - engines >=18 and CI matrix 20/22/latest (nodemw 0.27 needs node >=18) Result: npm audit --omit=dev clean; 11/11 mocha tests pass; jshint clean; all five nodemw APIs used by wiki2gource.js verified present.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SLOP-319
Summary
npm audit --omit=devondevelreports 11 vulnerabilities (4 critical, 2 high), rooted innodemw@0.17.0depending on the abandonedrequestpackage: request SSRF (critical), form-data CRLF injection + unsafe boundary (critical), json-schema/jsprim prototype pollution (critical), qs prototype pollution/DoS (high), underscore recursion DoS GHSA-qpx9-hpmf-5gmw (high), plus tough-cookie/uuid/diff/ajv moderates. This tool fetches arbitrary operator-supplied wiki domains over HTTPS, so the request chain sits directly on its core path.Mirrors the fixes upstream macbre/wiki-evolution already shipped (macbre#71 nodemw 0.25, macbre#73 color 5, npm audit fix):
nodemw^0.17.0 -> ^0.27.0 (request-> maintained@cypress/request@^4)async^3.2.1 -> ^3.2.6color^4.0.1 -> ^5.0.3 plusrequire(color).defaultin index.js (same as upstream commit 5aa1fc2)mocha^10 -> ^11.1.0overrides:underscore^1.13.8 clears the residual GHSA-qpx9-hpmf-5gmw (nodemw declares ^1.9.1, compatible)engines.node>=18 and CI matrix 20.x/22.x/latest (nodemw 0.27 requires Node >=18; old matrix tested 12.x-17.x which cannot install it)Verification
npm audit --omit=dev: found 0 vulnerabilities after this changenpm run lint(jshint) clean;node --checkclean on both entry points