1.8.2: a stale session cookie starts a fresh session instead of a 500 - #273
Merged
Merged
Conversation
…n instead of a 500 cPanel's shared session dir after an account is recreated: the file belongs to the old uid. PHP defines SID even on a failed session_start(), so the check must come first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cPanel's shared session dir after an account is deleted and recreated: the browser's PHPSESSID names a file owned by the old uid; session_start() fails; PHP defines SID even then, so Zend_Session cannot retry. Check the presented id's file BEFORE starting; fresh id when unreadable. Found in the second outside install round (TIGER-138). Proven on host3: the recreated site 500s on 1.8.1 with such a cookie.
🤖 Generated with Claude Code
https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ