Theme assets reach a split docroot; symlink-off copy at the asset base — 1.7.1 - #269
Merged
Merged
Conversation
…et base (1.7.1) Found by the first one-click cPanel install (TIGER-39 on host3, symlink() disabled, subdomain docroot inside public_html): Grey Mist activated but /_greymist/* 404'd. Two causes: nothing mirrored a theme's asset base from <root>/public into the docroot, and the symlink-off fallback published to _modules/<slug> where the theme's HTML does not point. linkPublicAssets() now mirrors every public/_* entry into a split docroot (co-located unchanged); Tiger_Theme::activate() publishes to the request's DOCUMENT_ROOT as well; Tiger_Install::publishOne() is the one link-or-copy unit for both. Tests: mirror in link + copy mode, no self-loop when co-located, publishOne respects a user's real directory. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found by the first one-click cPanel install through TigerWHM (host3,
symlink()disabled, subdomain docroot insidepublic_html): the activated theme rendered unstyled because/_greymist/*404'd.Tiger_Install::linkPublicAssets()mirrors every_*entry under<root>/public(a theme's asset base, a module's own publish) into a split docroot; co-located installs unchanged.Tiger_Theme::activate()publishes to the request'sDOCUMENT_ROOTtoo, and thesymlink()-off fallback copies to the theme's asset base instead of_modules/<slug>.Tiger_Install::publishOne()— the one link-or-copy unit for both.Test plan
InstallAssetsTest: +3 (mirror in link and copy mode with the marker; no self-loop when co-located;publishOnerespects a user's real dir).🤖 Generated with Claude Code
https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ