TigerButton: hosted busy spinner for the Google button — 1.6.4 - #267
Merged
Merged
Conversation
…ays inside its layout busy() prepended the injected spinner to the <button>, which on the gsi-material-button became a third child ahead of the flex content wrapper and wrapped "Continue with Google" onto a second line for the duration of the save. A descendant marked data-tg-busy-host now hosts the spinner (appended after its label); default behaviour is unchanged for every other button. tests/js/tiger.button.test.js covers both placements, done(), and the FontAwesome swap path; wired into the javascript CI job. Version 1.6.4. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TigerButton.busy()prepended its injected spinner to the<button>; on thegsi-material-buttonthat broke the flex layout and wrapped the label to a second line during the save (visible in the OAuth demo recording).data-tg-busy-hoston a descendant: the spinner is appended there instead. All other buttons unchanged.tiger.button.js(4, mutation-checked: reverting the fix fails the placement test), added to thejavascriptCI job.Test plan
node tests/js/tiger.button.test.js→ 4 pass; with the fix reverted → placement test fails./_theme/js/tiger.button.jscarries the change.🤖 Generated with Claude Code
https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ