Analytics: revoke on disconnect, Google-branded connect + data notice (TIGER-117/118) — 1.6.3 - #266
Merged
Merged
Conversation
…oduct data notice (TIGER-117, TIGER-118) TIGER-117 — disconnect() POSTs the refresh token to Google's revocation endpoint before clearing it locally. Fail-soft: unreachable Google still clears the local token; the controller reports whether the grant was revoked so the admin knows to revoke from their Google Account if not. DisconnectRevokeTest covers unreachable, no-token, and a real 200 via a local php -S server (asserts the token is in the POST body). TIGER-118 — the connect button now uses Google's gsi-material-button markup with the supplied inline-SVG G mark (light + dark variants in admin.css), text "Continue with Google". A Google-data notice above it names the single scope, where the data is rendered, that the broker never sees or stores it, retention, revocation, and links /privacy. Nine new analytics.* keys in seven locales. Remaining icon-font Google glyphs on the analytics screens swapped for neutral icons. Version 1.6.3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiger_Google_Analytics::disconnect()revokes the refresh token at Google before clearing it locally; fail-soft when Google is unreachable, and the settings screen reports whether the grant was revoked.gsi-material-button, inline-SVG G mark, light/dark), plus an in-product Google-data notice naming the scope, where data goes, retention, revocation and the privacy policy. 9 new keys × 7 locales.Test plan
DisconnectRevokeTest(3 tests, both mutations killed): unreachable → cleared butrevoked=false; no token → no request; real 200 from localphp -S→revoked=truewith token in body.style=.🤖 Generated with Claude Code
https://claude.ai/code/session_01L8p9pLJ3DFstG3xZuh2QgZ